Update Code to 1.88.1 (#6754)

* Update Code to 1.88.1
* Install node-gyp

---------

Co-authored-by: Asher <ash@coder.com>

.github/workflows/build.yaml

@@ -229,6 +229,11 @@ jobs:
         with:
           node-version-file: .node-version
 
+      # node-gyp is missing in (at least) npm 9.8.1.
+      # TODO: Remove once we update to npm>=10?
+      - name: Install node-gyp
+        run: npm install -g node-gyp
+
       - name: Fetch dependencies from cache
         id: cache-node-modules
         uses: actions/cache@v4

CHANGELOG.md

@@ -22,6 +22,21 @@ Code v99.99.999
 
 ## Unreleased
 
+## [4.23.0](https://github.com/coder/code-server/releases/tag/v4.23.0) - 2024-04-08
+
+Code v1.88.0
+
+## Changed
+
+- Updated to Code 1.88.0.
+- Updated Node to 18.18.2.
+
+## Fixed
+
+- Fix masking the exit code when failing to install extensions on the command
+  line outside the integrated terminal. Installing extensions inside the
+  integrated terminal still masks the exit code and is an upstream bug.
+
 ## [4.22.1](https://github.com/coder/code-server/releases/tag/v4.22.1) - 2024-03-14
 
 Code v1.87.2

ci/helm-chart/Chart.yaml

@@ -15,9 +15,9 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 3.18.1
+version: 3.19.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 4.22.1
+appVersion: 4.23.0

ci/helm-chart/values.yaml

@@ -6,7 +6,7 @@ replicaCount: 1
 
 image:
   repository: codercom/code-server
-  tag: '4.22.1'
+  tag: '4.23.0'
   pullPolicy: Always
 
 # Specifies one or more secrets to be used when pulling images from a

src/node/main.ts

@@ -52,12 +52,17 @@ export const runCodeCli = async (args: DefaultedArgs): Promise<void> => {
 
   try {
     await spawnCli(await toCodeArgs(args))
+    // Rather than have the caller handle errors and exit, spawnCli will exit
+    // itself.  Additionally, it does this on a timeout set to 0.  So, try
+    // waiting for VS Code to exit before giving up and doing it ourselves.
+    await new Promise((r) => setTimeout(r, 1000))
+    logger.warn("Code never exited")
+    process.exit(0)
   } catch (error: any) {
+    // spawnCli catches all errors, but just in case that changes.
     logger.error("Got error from Code", error)
     process.exit(1)
   }
-
-  process.exit(0)
 }
 
 export const openInExistingInstance = async (args: DefaultedArgs, socketPath: string): Promise<void> => {

test/integration/installExtension.test.ts

@@ -13,9 +13,10 @@ describe("--install-extension", () => {
   })
   it("should use EXTENSIONS_GALLERY when set", async () => {
     const extName = "author.extension"
-    const { stderr } = await runCodeServerCommand([...setupFlags, "--install-extension", extName], {
+    await expect(
-      EXTENSIONS_GALLERY: "{}",
+      runCodeServerCommand([...setupFlags, "--install-extension", extName], {
-    })
+        EXTENSIONS_GALLERY: "{}",
-    expect(stderr).toMatch("No extension gallery service configured")
+      }),
+    ).rejects.toThrow("No extension gallery service configured")
   })
 })