Fix false booleans in config file being parsed as true (#8053)

Options like `enable-remote-storage: false` in config.yaml are converted to
`--enable-remote-storage=false`, but the parser set any boolean option to
true regardless of its value. Booleans set to false are now ignored, the
same way optional strings set to false already are.
This commit is contained in:
Harsh Bhanushali
2026-10-14 06:31:10 +05:30
committed by GitHub
parent 41cf6f7eaf
commit 83670e50c6
2 changed files with 18 additions and 1 deletions

View File

@@ -436,7 +436,11 @@ export const parse = (
const option = options[key]
if (option.type === "boolean") {
;(args[key] as boolean) = true
// Booleans set to false (for example `--flag=false`, which is also how
// false values from the config file are passed in) are ignored.
if (value !== "false") {
;(args[key] as boolean) = true
}
continue
}