mirror of
https://github.com/coder/code-server.git
synced 2026-05-13 07:47:26 +02:00
Proxy path fixes (#4548)
* Fix issue where HTTP error status codes are not read. * Fix issues surrounding sessions when accessed from a proxy. - Updated vscode args to match latest upstream. - Fixed issues surrounding trailing slashes affecting base paths. - Updated cookie names to better match upstream's usage, debuggability. * Bump vendor. * Update tests. * Fix issue where tests lack cookie key. Co-authored-by: Asher <ash@coder.com>
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
import { field, logger } from "@coder/logger"
|
||||
import * as os from "os"
|
||||
import http from "http"
|
||||
import * as os from "os"
|
||||
import path from "path"
|
||||
import { Disposable } from "../common/emitter"
|
||||
import { plural } from "../common/util"
|
||||
@@ -37,8 +37,11 @@ export const runVsCodeCli = async (args: DefaultedArgs): Promise<void> => {
|
||||
try {
|
||||
await spawnCli({
|
||||
...args,
|
||||
// For some reason VS Code takes the port as a string.
|
||||
port: typeof args.port !== "undefined" ? args.port.toString() : undefined,
|
||||
/** Type casting. */
|
||||
"accept-server-license-terms": true,
|
||||
help: !!args.help,
|
||||
version: !!args.version,
|
||||
port: args.port?.toString(),
|
||||
})
|
||||
} catch (error: any) {
|
||||
logger.error("Got error from VS Code", error)
|
||||
|
||||
Reference in New Issue
Block a user